PYTHON-5314 Fix default imports#2300
Merged
ShaneHarvey merged 3 commits intomongodb:masterfrom Apr 22, 2025
Merged
Conversation
NoahStapp
approved these changes
Apr 22, 2025
Member
Author
|
drivers-pr-bot please backport to v4.12 |
Contributor
|
Sorry, unable to cherry-pick to v4.12, please backport manually. Here are approximate instructions:
|
ShaneHarvey
added a commit
to ShaneHarvey/mongo-python-driver
that referenced
this pull request
Apr 23, 2025
ShaneHarvey
added a commit
that referenced
this pull request
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5314 Fix default imports
Oddly, ruff complained about the existing code
precommit fails:
But if I remove the noqa comment, ruff will delete the imports because it thinks they're unused...
The only way I found to avoid this was to change the imports to
from pymongo import uri_parser.