PYTHON-5386 Better test assertions for isinstance#2347
PYTHON-5386 Better test assertions for isinstance#2347sleepyStick merged 2 commits intomongodb:masterfrom
Conversation
|
There is an existing patch(es) for this commit SHA: Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'. |
|
Can you make a sub-task on the JIRA ticket for this work? Tracking each assertion type improvement separately would be helpful. |
yes, good call, done! Just renamed the PR name to use the new ticket / subtask number. |
There was a problem hiding this comment.
Great work! Please update the ticket in the title to the correct PYTHON-5386 before merging.
Oops accidentally had the wrong ticket number...(only realized after i had created a draft PR >.<)
But this just changes assertions for isinstance calls:
self.assertTrue(isinstance(..., ...))->self.assertIsInstance(..., ...)self.assertFalse(isinstance(..., ...))->self.assertNotIsInstance(..., ...)