PYTHON-5421 continued - update changelog, update docstring, and add testing#2420
Merged
sleepyStick merged 5 commits intomongodb:masterfrom Jul 7, 2025
Merged
PYTHON-5421 continued - update changelog, update docstring, and add testing#2420sleepyStick merged 5 commits intomongodb:masterfrom
sleepyStick merged 5 commits intomongodb:masterfrom
Conversation
aclark4life
requested changes
Jul 7, 2025
Contributor
aclark4life
left a comment
aclark4life
left a comment
There was a problem hiding this comment.
It may just be me but I would do options instead of 'options' what do you think? Also I'd say "parse_uri's options parameter" instead of parse_uri's options. </nit>
Contributor
Author
Totally makes sense, i'm kinda terrible with words sometimes so i'll happily suggest any revisions to my text :) |
aclark4life
reviewed
Jul 7, 2025
pymongo/asynchronous/uri_parser.py
Outdated
| :param srv_service_name: A custom SRV service name | ||
|
|
||
| .. versionchanged:: 4.14 | ||
| 'options' is now type ``dict`` as opposed to a ``_CaseInsensitiveDictionary``. |
Contributor
Author
There was a problem hiding this comment.
Sorry missed this, good catch!
just options right?
aclark4life
reviewed
Jul 7, 2025
pymongo/synchronous/uri_parser.py
Outdated
| :param srv_service_name: A custom SRV service name | ||
|
|
||
| .. versionchanged:: 4.14 | ||
| 'options' is now type ``dict`` as opposed to a ``_CaseInsensitiveDictionary``. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up PR to #2413