PYTHON-5429 Server command is case sensitive#2421
Closed
aclark4life wants to merge 8 commits intomongodb:masterfrom
aclark4life:PYTHON-5429
Closed
PYTHON-5429 Server command is case sensitive#2421aclark4life wants to merge 8 commits intomongodb:masterfrom aclark4life:PYTHON-5429
aclark4life wants to merge 8 commits intomongodb:masterfrom
aclark4life:PYTHON-5429
Conversation
Via Erwin Pe, "libmongocrypt does case sensitive comparison of command names against the list of eligible commands."
ShaneHarvey
requested changes
Jul 3, 2025
Contributor
Author
|
I don't see that many but I'll fix those. |
Contributor
|
@aclark4life don't forget the |
Contributor
Author
ShaneHarvey
reviewed
Jul 7, 2025
Member
ShaneHarvey
left a comment
ShaneHarvey
left a comment
There was a problem hiding this comment.
I'm trying to decide if we should change this in pymongo at all. What are the cons of just waiting on the libmongocrypt bug fix release?
doc/changelog.rst
Outdated
| - Introduces a minor breaking change. When encoding :class:`bson.binary.BinaryVector`, a ``ValueError`` will be raised | ||
| if the 'padding' metadata field is < 0 or > 7, or non-zero for any type other than PACKED_BIT. | ||
| - Fixed a bug that raised ``EncryptionError`` when using :meth:`pymongo.mongo_client.MongoClient.server_info` with an | ||
| encrypted connection. |
Member
There was a problem hiding this comment.
Can you add another sentence explaining that server_info() now runs "buildInfo" instead of "buildinfo"? That could be a breaking change if an app is matching the command name in events or log messages.
aclark4life
requested review from
ShaneHarvey and
sleepyStick
and removed request for
Jibola and
ShaneHarvey
Contributor
Author
Probably fine to wait since I've already fixed the issue in Django. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Via Erwin Pe, "libmongocrypt does case sensitive comparison of command names against the list of eligible commands."