PYTHON-5518: withTransaction API retries too frequently#2600
PYTHON-5518: withTransaction API retries too frequently#2600sleepyStick merged 19 commits intomongodb:backpressurefrom
Conversation
|
@sleepyStick is this ready for review? |
yes? the spec for these changes are still in review -- if the spec is good/doesn't have any more changes, then this is ready for review? |
There was a problem hiding this comment.
Why do we need random to be deterministic here? Can you expand this comment with a short motivation?
54bd6f0 to
0010325
Compare
Add adaptive token bucket based retry policy. Successfully completed commands deposit 0.1 token. Failed retry attempts consume 1 token. A retry is only permitted if there is an available token. Token bucket starts full with the maximum 1000 tokens.
…tion rate limiter triggers (mongodb#2509) Co-authored-by: Iris <58442094+sleepyStick@users.noreply.github.com> Co-authored-by: Noah Stapp <noah.stapp@mongodb.com> Co-authored-by: Shane Harvey <shnhrv@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
f2e53c6 to
1060137
Compare
…r connection rate limiter triggers (mongodb#2509)" This reverts commit a99645e.
…)" This reverts commit 1820f97.
|
^ not sure why PYTHON-5536 and PYTHON-5506 are part of this branch history / the commits that need to be merged in? reverted them to remove those changes from this PR |
|
Any idea why there's a bunch of failures? |
Honestly no.... |
|
The GHA failures are due to this branch and |
Since Shane is OOO and I've addressed his comments, I'm gonna remove him as a reviewer :)
PYTHON-5518
Summary
_BACKOFF_INITIAL, _BACKOFF_MAX, and the growth rate have now been experimented with using the previous with_transaction benchmark and values are chosen based on what experimentally did the best.
Changes in this PR
Testing Plan
prose test
Screenshots (optional)
Checklist
Checklist for Author
Checklist for Reviewer {@primary_reviewer}
Focus Areas for Reviewer (optional)