refactor(NODE-7323): more closely align SDAM error handling with spec pseudocode#4803
Merged
PavelSafronov merged 6 commits intomainfrom Dec 1, 2025
Merged
refactor(NODE-7323): more closely align SDAM error handling with spec pseudocode#4803PavelSafronov merged 6 commits intomainfrom
PavelSafronov merged 6 commits intomainfrom
Conversation
387f111 to
0b6dce7
Compare
durran
approved these changes
Nov 26, 2025
Member
|
One tsconfig error. Should we ignore on this PR and fix on another? |
PavelSafronov
approved these changes
Nov 26, 2025
Contributor
PavelSafronov
left a comment
There was a problem hiding this comment.
Minor comment about avoiding a return, but otherwise looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
While working on #4800, I was reviewing our SDAM error handling for the first time in a while. Our implementation is slightly different from the pseudocode, which made cross referencing them challenging. I refactored the SDAM error handling the best I could:
isSDAMUnrecoverableErrorbecameisStateChangeError).Someday I'd like to finish this alignment. The largest barrier to fully aligning the implementation with the spec's is that in Node, clearing the pool is done by attaching the
ResetPoollabel to an error and callingmarkServerUnknown. In the spec algorithm:This is the last real difference between our implementation and the spec's pseudocode but this refactor would be much more invasive than the refactor in this PR, so I've deferred it for now.
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript