test(NODE-7426): Add appName to OIDC test failpoints#4869
test(NODE-7426): Add appName to OIDC test failpoints#4869PavelSafronov wants to merge 2 commits intomongodb:mainfrom
Conversation
PavelSafronov
force-pushed
the
NODE-7426
branch
from
7cdb6ac to
553631d
Compare
dariakp
added
the
Primary Review
| } | ||
|
|
||
| // Test descriptions use `appName` and `appname` interchangeably | ||
| if ( |
There was a problem hiding this comment.
You should not need to modify the unified test runner, since there was no change to the unified test runner specification. The appName for unified tests is already passed in directly via the spec files themselves.
You may find it helpful to look at the reference implementations linked in the spec PR (mongodb/specifications#1891), for example the python one here.
| }); | ||
|
|
||
| afterEach(async function () { | ||
| // explicitly remove the fail point to prevent interaction betweet test runs |
There was a problem hiding this comment.
The annotations are helpful, however, the new requirement in the spec is to ensure that we not only remove the failpoint but also always set the appName for any failpoint created. In this file, there are two types of clients - the regular one and the util client (with the util clients being used to set fail points), with some clients instantiated via new MongoClient and others via the getClient method, so we want to make sure that we always configure the clients being tested and the failpoints set in the test with an appName.
2 participants
Description
Summary of Changes
Updated OIDC test specs.
Double-checked that failpoints are being removed
Updated UnifiedMongoClient to always configure an
appName, as either a passed-in value or a unique identifier, as called out for OIDC tests in mongodb/specifications@4d11668Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript