Skip to content

feat(NODE-7142): Exponential backoff and jitter in retry loops #4871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baileympearson wants to merge 11 commits into
base: main
Choose a base branch
from
+12,769 −80
Open

feat(NODE-7142): Exponential backoff and jitter in retry loops #4871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7c08fb5
POC
baileympearson Feb 10, 2026
4100da7
deposit retry tokens only on retries, update maxAttempts property con…
tadjik1 Feb 19, 2026
091e989
update to latest, small clean-ups
tadjik1 Feb 19, 2026
680ee08
add timeoutContext to retry selectServer
tadjik1 Feb 19, 2026
0c36556
revert non-compliant spec change
tadjik1 Feb 19, 2026
a4caf38
always cleanup local timeout (also for sharded clusters)
tadjik1 Feb 19, 2026
89eafde
do not leak the timeout also in normal path finally block
tadjik1 Feb 19, 2026
50d5c2c
run all tests
tadjik1 Feb 19, 2026
85f10c3
define constants
tadjik1 Feb 19, 2026
b048983
export TokenBucket
tadjik1 Feb 19, 2026
adcdc4f
retry batching commands only on retryable errors
tadjik1 Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions src/cmap/connect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ export interface HandshakeDocument extends Document {
compression: string[];
saslSupportedMechs?: string;
loadBalanced?: boolean;
backpressure: true;
}

/**
Expand All @@ -241,6 +242,7 @@ export async function prepareHandshakeDocument(

const handshakeDoc: HandshakeDocument = {
[serverApi?.version || options.loadBalanced === true ? 'hello' : LEGACY_HELLO_COMMAND]: 1,
backpressure: true,
helloOk: true,
client: clientMetadata,
compression: compressors
Expand Down
3 changes: 3 additions & 0 deletions src/cmap/connection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,9 @@ export class Connection extends TypedEventEmitter<ConnectionEvents> {
this.throwIfAborted();
}
} catch (error) {
if (options.session != null && !(error instanceof MongoServerError)) {
updateSessionFromResponse(options.session, MongoDBResponse.empty);
Copy link
Member

@tadjik1 tadjik1 Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will consequently transition the transaction into TRANSACTION_IN_PROGRESS state (as .empty has no error and no success labels).

Copy link
Contributor

@nbbeeken nbbeeken Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have coverage for this through the spec tests or is there a bespoke node test to write for this?

}
if (this.shouldEmitAndLogCommand) {
this.emitAndLogCommand(
this.monitorCommands,
Expand Down
1 change: 1 addition & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ export {
MongoWriteConcernError,
WriteConcernErrorResult
} from './error';
export { TokenBucket } from './token_bucket';
Copy link
Contributor

@nbbeeken nbbeeken Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export { TokenBucket } from './token_bucket';
export type { TokenBucket } from './token_bucket';

Not a strong opinion but if this isn't public API then it need not be exported (if we do change this can we move it below line 176)

export {
AbstractCursor,
// Actual driver classes exported
Expand Down
Loading