Conversation
seungpark
commented
Mar 20, 2025
.drone.yml
Outdated
| trigger: | ||
| branch: | ||
| - main | ||
| - DOP-5513 |
Contributor
Author
There was a problem hiding this comment.
Revert changes before merge
rayangler
reviewed
Mar 20, 2025
rayangler
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
DOP-5513
Notes
This PR adds middleware logic to the Express server so that we check the request origin, and append a Response Header for
access-control-allow-originto let the browser know that this is an ok CORS request.Staging
Tested using the stage API with credentials included in the request:
First screenshot shows
response.headermissingAccess-Control-Allow-Originbecause it is from a random domain:Second screenshot shows

response.headerwithAccess-Control-Allow-Originbecause it is from a spoofednetlify.appdomain:Note:
Cookierequest header to bypass CorSecureREADME updates