Skip to content

Fix spec pseudocode for retryable reads #1896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
papafe wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix spec pseudocode for retryable reads #1896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions source/retryable-reads/retryable-reads.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,10 @@ function executeRetryableRead(command, session) {
if (timeoutMS != null && isExpired(timeoutMS) {
throw previousError;
}
/* CSOT is not enabled, and we have already tried once */
if (timeoutMS == null && retrying) {
throw previousError;
}
continue;
}

Expand Down Expand Up @@ -359,6 +363,12 @@ function executeRetryableRead(command, session) {
updateTopologyDescriptionForNotWritablePrimaryError(server, notPrimaryError);
previousError = notPrimaryError;
previousServer = server;
} catch (Exception error when error.code in RETRYABLE_ERROR_CODES) {
/* Catches remaining server errors with retryable error codes as defined
* in the Retryable Error section. */
updateTopologyDescriptionForError(server, error);
previousError = error;
previousServer = server;
} catch (DriverException error) {
if ( previousError != null ) {
throw previousError;
Expand Down
Loading