Conversation
Author
|
So based on background discussions the code has an issue, with the hardcoded moutnpoint of the control group which is for sure wrong while it can be differently mounted. My proposed resolution for this, is the following, (what i will shortly implement till than please do not merge this pull request.) the real mountpoints of cgroup pseudo filesystems can be gathered from /proc/mounts , so i will list the moutnpoints from there and will read the config files recursively on all mounted controllers. Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for checking cgroups, at least tested and works for RHEL. Lists the config files, checks the services, and list the hierarchies followed by all the settings and states inside (including the tasks also,). Raise your concerns and will adopt accordingly.
Best,
Attish