This repository was archived by the owner on Jun 5, 2020. It is now read-only.
feat(unsubscribe): Add unsubscribe function#7
Open
declanelcocks wants to merge 1 commit intomonterail:masterfrom
Open
feat(unsubscribe): Add unsubscribe function#7declanelcocks wants to merge 1 commit intomonterail:masterfrom
declanelcocks wants to merge 1 commit intomonterail:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using your library for some simple real time notifications and noticed that on logout the connection was not being destroyed. As well as that, I needed to subscribe and unsubscribe from some channels based on specific variables. This function I've added works for me, but it's as basic as it can get, so feel free to add any data or callbacks to it.
I realise this repo is quite inactive, but thanks for the great angular wrapper 👍