Add BytesView constructors and unchecked string conversion#3200
Open
Add BytesView constructors and unchecked string conversion#3200
Conversation
Collaborator
Pull Request Test Coverage Report for Build 2526Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
BytesViewAPI withBytesby providing constructors and the unchecked string helper that mirrorBytescounterparts.BytesViewhelpers in the builtins interface so external code can use them without workarounds.Description
BytesView::from_array(ArrayView[Byte]) -> BytesViewto construct a view from an array by delegating toBytes::from_array(... )[:].BytesView::from_iter(Iter[Byte]) -> BytesView(declared with#alias(from_iterator, deprecated)) to construct a view from an iterator by delegating toBytes::from_iter(... )[:].BytesView::to_unchecked_string(self, offset? : Int, length? : Int) -> Stringwhich delegates toBytes::to_unchecked_stringusing the view start offset and validates bounds.pkg.generated.mbti) so the newBytesViewAPIs are published.Testing
moon infowhich completed successfully and updated the generated interface without errors.moon fmtwhich completed successfully and formatted the modified files.Codex Task