Conversation
myfreess
force-pushed
the
fix-sync-test
branch
from
c28209c to
d18a5b1
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 418e7600dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| mbti -> Mbti | ||
| : LIDENT STRING ioption(";") imports sigs EOF { Mbti::{package_name: $2, imports: $4, sigs: $5} } | ||
| : PACKAGE STRING ioption(";") imports sigs EOF { Mbti::{package_name: $2, imports: $4, sigs: $5, loc : mk_loc($sloc)} } |
There was a problem hiding this comment.
This production now requires a PACKAGE token to start every .mbti file, but the lexer changes in this commit never add a "package" -> PACKAGE keyword mapping (the keyword table only adds nobreak). In practice, package "..." still lexes as LIDENT("package"), so the parser fails on the first token and cannot parse normal .mbti headers.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@myfreess let‘s fix this in another PR
ok
|
LGTM |
2 participants
No description provided.