MAF-19232: feat(e2e): use template on e2e tests#51
Draft
seongsukwon-moreh wants to merge 8 commits intomainfrom
Draft
MAF-19232: feat(e2e): use template on e2e tests#51seongsukwon-moreh wants to merge 8 commits intomainfrom
seongsukwon-moreh wants to merge 8 commits intomainfrom
Conversation
…plates for meta-llama model - Changed the test model to "meta-llama/Llama-3.2-1B-Instruct" and added a new test template "quickstart-vllm-meta-llama-llama-3.2-1b-instruct-amd-mi250-tp2" in e2e workflows. - Removed deprecated InferenceServiceTemplates and updated the InferenceService data structure to include template references. - Introduced new inference service YAML templates for performance and quality benchmarks, enhancing the testing framework. - Updated environment variable handling and resource management in the e2e tests for improved clarity and maintainability.
…mance and quality tests - Added functions to create and delete model Persistent Volumes (PV) and Persistent Volume Claims (PVC) in the e2e testing framework. - Updated performance and quality test cases to utilize the new PV and PVC management, enhancing resource handling during tests. - Refactored existing code to remove deprecated PV and PVC creation methods, ensuring cleaner and more maintainable test scripts.
- Updated the ParseImage function to return an error if the image format is invalid, ensuring better validation. - Modified the createInferencePerfJob function to handle parsing errors gracefully, improving robustness in performance tests. - Reorganized the deletion of Heimdall in quality tests for better clarity and consistency.
… tests - Changed the paths for ModelPV and ModelPVC constants to reflect the new directory structure, ensuring alignment with the latest configuration standards. - This update enhances maintainability and clarity in the e2e testing framework.
…functions and streamline gateway service retrieval - Eliminated the CreateInferenceServiceTemplate and DeleteInferenceServiceTemplate functions to reduce redundancy. - Introduced a new GetGatewayServiceName function for improved clarity in retrieving the Gateway service name. - Enhanced error handling in the GetGatewayServiceName function to ensure better feedback when the service is not found.
…AML templates for performance and quality tests - Modified GetInferenceServiceData function to include an 'isKind' parameter for better context handling. - Updated performance and quality test files to utilize the new parameter in data retrieval. - Enhanced inference service YAML templates to conditionally include resource requests and limits based on the 'isKind' flag, improving resource management in tests.
…te data retrieval for inference tests - Added new environment variables for test templates: TEST_TEMPLATE_PREFILL and TEST_TEMPLATE_DECODE. - Updated performance and quality test files to utilize the new template variables for data retrieval, improving clarity and maintainability in test configurations. - Ensured consistency in the handling of inference service data across different test scenarios.
…ource management - Introduced new YAML templates for Persistent Volume (PV) and Persistent Volume Claim (PVC) to support model storage in the e2e testing framework. - Updated constants to reflect the new template paths, ensuring consistency and maintainability in test configurations. - These additions improve the handling of storage resources during performance and quality tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.