Draft
Conversation
a66d68f to
cad9a19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix /v1/chat/completions/render endpoint to properly serialize Harmony model messages.
The render endpoint was failing with TypeError: Object of type Message is not JSON serializable when used with Harmony models (e.g., openai/gpt-oss-20b). This is because Harmony models return OpenAIMessage Pydantic objects in the conversation, which cannot be directly serialized to JSON.
This PR:
Adds proper serialization logic in api_router.py to handle both Pydantic models (via model_dump()) and TypedDict objects
Updates test assertions to handle both standard message format (role key) and Harmony format (nested author dict)
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.