This repository was archived by the owner on Aug 1, 2025. It is now read-only.
Open
Conversation
Add username to endpoint to better identify the player
|
Any chance you can take a look at this PR @morgan-vanv |
Add username to endpoint to better identify the player Fix bug where player status is being emitted, despite state of the config option
Owner
|
I'm on vacation atm, but I will review this when I return. Sometime within
the next week.
Thanks for taking interest in this and making a PR! Looking forward to
reviewing it
…On Tue, Sep 17, 2024, 12:33 PM QuBerto ***@***.***> wrote:
Any chance you can take a look at this PR @morgan-vanv
<https://github.com/morgan-vanv>
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALHDBHBRE7KNKFSZE4WOHVDZXBKXFAVCNFSM6AAAAABOHF4ZZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJWGQYDIOJSGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Owner
|
Quick question regarding this before I approve/merge: has any testing been done on this to ensure it is functioning as intended? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add loot endpoint for raids etc
Add username to endpoint to better identify the player