Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions include/argparse/argparse.hpp
100755 → 100644
Original file line number Diff line number Diff line change
Expand Up @@ -560,6 +560,16 @@ namespace argparse {
if (arg_i < arguments_flat.size())
arg_entries[arg_i]->_convert(arguments_flat[arg_i]);
}

if (arg_i == arg_entries.size() && arg_i < arguments_flat.size()) {
if (raise_on_error) {
throw std::runtime_error("Too many positional values");
} else {
std::cerr << "Too many positional values" << std::endl;
exit(-1);
}
}

size_t arg_j = 1;
for (size_t j_end = arg_entries.size() - arg_i; arg_j <= j_end; arg_j++) { // iterate from back to front, to ensure non-multi-arguments in the front and back are given preference
size_t flat_idx = arguments_flat.size() - arg_j;
Expand Down
15 changes: 13 additions & 2 deletions tests/tests.cpp
100755 → 100644
Original file line number Diff line number Diff line change
Expand Up @@ -204,14 +204,25 @@ void TEST_THROW() {
}

{
std::string command = "argparse_test source_path source_path";
std::string command = "argparse_test source_path";
const auto &[argc, argv] = get_argc_argv(command);
try {
auto args = argparse::parse<Args>(argc, argv, true);
} catch (const std::runtime_error &e) {
assert(std::string(e.what()) == "Argument missing: -a,--alpha (required alpha value)");
}
}

{
std::string command = "argparse_test source_path source_path";
const auto &[argc, argv] = get_argc_argv(command);
try {
auto args = argparse::parse<Args>(argc, argv, true);
} catch (const std::runtime_error &e) {
assert(std::string(e.what()) == "Too many positional values");
}
}

}

void TEST_SUBCOMMANDS() {
Expand Down Expand Up @@ -331,7 +342,7 @@ int main(int argc, char* argv[]) {
std::cout << "Magic Enum not installed in this system, therefore native enum support disabled" << std::endl;
#endif

TEST_SUBCOMMANDS();
TEST_SUBCOMMANDS();
TEST_SHORT_GROUP();
TEST_EQUALS();
TEST_EMPTY_MULTI();
Expand Down