Changes to the currency_converter.py file in the Main branch #2
Open
KonstantineTzaferis wants to merge 2 commits intomosh-hamedani:mainfrom
Open
Changes to the currency_converter.py file in the Main branch #2KonstantineTzaferis wants to merge 2 commits intomosh-hamedani:mainfrom
KonstantineTzaferis wants to merge 2 commits intomosh-hamedani:mainfrom
Conversation
Changes made in the currency_converter.py file
In the main function in the last print statement before the changes was -- print(f'{amount} {source_currency} is equal to {converted_amount:.2f}')
The changes were that in the print statement the target currency is mentioned so we know to which currency code the end amount refers to
Example: 500 USD is equal to 430 EUR
…rrencyConverter.py Add files via upload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the last code line in the main function where we print the amounts of the source and the converted currency we added the target currency in the print statement in order to know to which currency code the conversion refers to.
Before changes: 500 USD is equal to 430.
After changes: 500 USDF is equal to 430 EUR.