Merged
Conversation
JafarAbdi
approved these changes
Dec 3, 2021
Member
As far as I know, there's no easy way to do it, a couple months ago I made a PR that hopefully will make our life easier. unfortunately, it still not merged yet |
Codecov Report
@@ Coverage Diff @@
## main #884 +/- ##
==========================================
+ Coverage 56.81% 56.83% +0.02%
==========================================
Files 200 200
Lines 21659 21659
==========================================
+ Hits 12304 12307 +3
+ Misses 9355 9352 -3
Continue to review full report at Codecov.
|
AndyZe
approved these changes
Dec 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a commit that I extracted form #452. The warning should be a debug message, it seems to have been merged as part of some verbose debugging attempt. Related note: Are we missing best practices on how to use and filter log messages properly? I've seen temporarily increased logger levels like this quite often and it should not be necessary.