Provide feedback during ExecuteTaskSolution action#653
Provide feedback during ExecuteTaskSolution action#653rhaschke merged 1 commit intomoveit:masterfrom
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #653 +/- ##
==========================================
+ Coverage 59.02% 59.03% +0.02%
==========================================
Files 97 97
Lines 9001 9004 +3
==========================================
+ Hits 5312 5315 +3
Misses 3689 3689 ☔ View full report in Codecov by Sentry. |
| no = solution.sub_trajectory.size()](const plan_execution::ExecutableMotionPlan* /*plan*/) { | ||
| // publish feedback | ||
| moveit_task_constructor_msgs::ExecuteTaskSolutionFeedback feedback; | ||
| feedback.sub_id = i; |
There was a problem hiding this comment.
Just a quick remark. If we keep it as is now (publishing the feedback only after the subtrajectory finishes), I think it makes more sense to use i + 1 here to match what is parsed in exec_traj.description_. Otherwise, if we decide to publish feedback at the start of the subtrajectory as well, publishing 0 initially would be reasonable.
Alternative implementation to #652