Skip to content

Python 3 Update#23

Open
DomAmato wants to merge 2 commits intomozes:masterfrom
hologram-io:master
Open

Python 3 Update#23
DomAmato wants to merge 2 commits intomozes:masterfrom
hologram-io:master

Conversation

@DomAmato
Copy link

Not sure if you are actively maintaining this code base anymore.

Here is a python 3 update

If not would you be ok with either transfering or allowing a hard fork (like pycrypto and pycryptodome did)

@DomAmato DomAmato force-pushed the master branch 2 times, most recently from 7aabfd5 to 3c8c9d6 Compare April 15, 2020 00:23
@DomAmato DomAmato force-pushed the master branch 3 times, most recently from c551042 to 9bbe402 Compare April 22, 2020 18:46
@theduderog
Copy link
Contributor

Hi @DomAmato, I'm not able to maintain it anymore Happy to transfer it.

@DomAmato
Copy link
Author

DomAmato commented Sep 4, 2020

cool, let me know if there is anything you need from me but you can just transfer it to my personal account and I can move it to a final destination.

@laf0rge
Copy link

laf0rge commented Aug 12, 2022

Hi @theduderog, @DomAmato, is there any progress about the transfer? There is a working python3 port around for years, but it is not installable via pip on python3, as the last version in pypi is version 0.3 (python 2.7 only) from 9 years ago.

Thanks for any help in unblocking this.

* Fix bug in length value not resetting after decoding

also added a type for network error codes to better show what they are, even though the spec is not honored in most implementations.

* remove old python versions

* add a test to do decode and encoding with the same encoder

* add test to check if patch works

uncommenting the code fix causes the test to fail

* make field names of named tuples easier to read
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants