Skip to content

chore: Update to 0.8.0#52

Open
jrconlin wants to merge 2 commits intomainfrom
chore/version_bump
Open

chore: Update to 0.8.0#52
jrconlin wants to merge 2 commits intomainfrom
chore/version_bump

Conversation

@jrconlin
Copy link
Member

@jrconlin jrconlin commented Aug 8, 2023

Update all sub crates to same core version.
Update library crates to latest version.
Address clippy issues in middleware.

Update for pending package release

Update all sub crates to same core version.
Update library crates to latest version.
Address clippy issues in middleware.
@jrconlin jrconlin requested review from pjenvey and robjtede August 8, 2023 21:27
]

[workspace.package]
version = "0.8.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you should do workspace lib versioning like this. Recommend keeping each crate with it's own version field. Other shared fields below here make sense though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I go back and forth about this quite a bit. The plus being when we tag a release, do a library check, etc. we only have one location we need to update.
The downside is that these crates are very loosely bound together under a fairly arbitrary collector.

I'll revert the version number change for now, but I still kinda would like to keep the version work simplified where possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants