Open
Conversation
Update all sub crates to same core version. Update library crates to latest version. Address clippy issues in middleware.
robjtede
reviewed
Aug 8, 2023
| ] | ||
|
|
||
| [workspace.package] | ||
| version = "0.8.0" |
Collaborator
There was a problem hiding this comment.
I don't think you should do workspace lib versioning like this. Recommend keeping each crate with it's own version field. Other shared fields below here make sense though.
Member
Author
There was a problem hiding this comment.
I go back and forth about this quite a bit. The plus being when we tag a release, do a library check, etc. we only have one location we need to update.
The downside is that these crates are very loosely bound together under a fairly arbitrary collector.
I'll revert the version number change for now, but I still kinda would like to keep the version work simplified where possible.
robjtede
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update all sub crates to same core version.
Update library crates to latest version.
Address clippy issues in middleware.
Update for pending package release