fix syncstorage DB cfg key in default config#1430
Open
s644 wants to merge 2 commits intomozilla-services:masterfrom
Open
fix syncstorage DB cfg key in default config#1430s644 wants to merge 2 commits intomozilla-services:masterfrom
s644 wants to merge 2 commits intomozilla-services:masterfrom
Conversation
Member
|
Looks good, but going to hold of on merging this until @ethowitz finishes his crate reorg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes the path for syncstorage database key. In my setup (Debian, self compiled, NO docker) I wasn't able to connect to my database with another user/password than root/nopwd via config file. I figured out that the key's parent was missing.
Testing
Run
make runwith and without default values (e.g. some user db user than root)