Conversation
chenba
force-pushed
the
chore/cargo-upgrade-stor-436
branch
from
52a5e71 to
cda0042
Compare
| // capture it, and then turn it off before we run out of money. | ||
| maybe_emit_metrics(&metrics, reportable_err); | ||
| debug!("Sentry: Not reporting error (service error): {:?}", error); | ||
| slog::debug!( |
There was a problem hiding this comment.
Doh, this again! Autopush was hit by this here (sorry I totally forgot about this).
Per my comment there I thought their new release was going to solve this so this change wouldn't be necessary, which they finally released last month?
There was a problem hiding this comment.
@pjenvey nice catch, thanks. I captured the original cargo upgrade output in the jira and looks like it didn't upgrade slog-scope. I just tried it again and it did upgrade slog-scope. Not sure what the deal is but I think the updated PR is ready now.
chenba
force-pushed
the
chore/cargo-upgrade-stor-436
branch
3 times, most recently
from
33a1520 to
e397438
Compare
|
sorry I screwed up a rebase. Setting this back to a draft for now. |
chenba
force-pushed
the
chore/cargo-upgrade-stor-436
branch
from
e397438 to
ce9e3c2
Compare
chenba
force-pushed
the
chore/cargo-upgrade-stor-436
branch
from
ce9e3c2 to
d471a96
Compare
| slog-envlogger = "2.2.0" | ||
| slog-mozlog-json = "0.1" | ||
| slog-scope = "4.3" | ||
| slog-scope = "4.4" |
There was a problem hiding this comment.
wait WHAT I'm dying here
There was a problem hiding this comment.
oh right never mind, 4.4.1 is installed in Cargo.lock.
2 participants
And updated slog calls to get rid of deprecation warnings...which is the majority of the changes by file count. I can move that into another commit/PR if that's easier to review.
Closes the rust deps part of STOR-436