Move login breach fields into meta record and add password reuse detection for breach alerts #7155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jo
force-pushed
the
breach-alert-meta
branch
9 times, most recently
from
b3c471f to
03586ff
Compare
jo
changed the title
Move the previously introduced login breach-related fields `time_of_last_breach` and `time_last_breach_alert_dismissed` from LoginFields into LoginMeta struct, to group internally handled fields which are not directly updateable.
Add breachesL table (schema v4) to track breached passwords and enable cross-domain password reuse detection. New APIs: - are_potentially_vulnerable_passwords(ids) - Batch check, returns GUIDs - is_potentially_vulnerable_password(id) - Single login check Batch API decrypts breachesL once and uses HashSet for efficient lookups (O(M + N) vs O(M * N) for repeated single checks).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the previously introduced login breach-related fields
time_of_last_breachandtime_last_breach_alert_dismissedfrom LoginFields into LoginMeta struct, to group internally handled fields which are not directly updateable.Add breachesL table (schema v4) to track breached passwords and enable cross-domain password reuse detection.
New APIs:
are_potentially_vulnerable_passwords(ids)- Batch check, returns GUIDsis_potentially_vulnerable_password(id)- Single login checkBatch API decrypts breachesL once and uses HashSet for efficient lookups (O(M + N) vs O(M * N) for repeated single checks).
This is the Phabricator patch for Desktop support.
Pull Request checklist
[ci full]to the PR title.