Skip to content

feat(viaduct-reqwest): set client user-agent from viaduct settings #7165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Almaju wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −7
Open

feat(viaduct-reqwest): set client user-agent from viaduct settings #7165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions components/support/viaduct-reqwest/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,9 @@ static CLIENT: Lazy<reqwest::blocking::Client> = Lazy::new(|| {
} else {
reqwest::redirect::Policy::none()
});
if cfg!(target_os = "ios") {
// The FxA servers rely on the UA agent to filter
// some push messages directed to iOS devices.
// This is obviously a terrible hack and we should
// probably do https://github.com/mozilla/application-services/issues/1326
// instead, but this will unblock us for now.
builder = builder.user_agent("Firefox-iOS-FxA/24");

if let Some(user_agent) = &settings.default_user_agent {
builder = builder.user_agent(user_agent);
}
// Note: no cookie or cache support.
builder
Expand Down