Skip to content
This repository was archived by the owner on Dec 17, 2019. It is now read-only.

Added field for a 'badge awarding badge'#172

Open
askvictor wants to merge 2 commits intomozilla:masterfrom
askvictor:d9d1d2863d74bda5f039643229ff8f46f3fc55c4
Open

Added field for a 'badge awarding badge'#172
askvictor wants to merge 2 commits intomozilla:masterfrom
askvictor:d9d1d2863d74bda5f039643229ff8f46f3fc55c4

Conversation

@askvictor
Copy link
Contributor

No description provided.

…-awarding of a badge when a set number of prerequisites met e.g. Badge Foo is awarded when 3 out of the 5 prerequisites have been obtained.
@willkg
Copy link
Member

willkg commented Aug 24, 2013

I don't understand what this pull request is doing. Can you explain the motivation behind this? What's the use-case example for auto-awarding a badge when only some of the prerequisites have been met?

@askvictor
Copy link
Contributor Author

oops; stuffed up my PR. This is a different feature to #171 - it should create a field which references a badge, which, when held by the user, allows them to award the current badge. Think of it like badge-based permissions. I'll try to get the PR fixed up soon, but might not have time in the very near future.

@willkg
Copy link
Member

willkg commented Aug 25, 2013

Ahh... got it! Yeah, I'll keep an eye out for the fixed PR. Thank you for clarifying!

@lmorchard
Copy link
Contributor

My feedback here is similar to the prereqs PR - that is, this logic probably would be happier living in a badges.py as a signal handler.

Of course, that doesn't give us the extra field added to the model. I think that's fine for a site that has most of its badges defined in badges.py - you can just encode the relationships there. But, for a "multiplayer" site like badges.mozilla.org, we might need some thought behind how to store this relationship if the core model isn't extended.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants