This repository was archived by the owner on Dec 17, 2019. It is now read-only.
Fix #158: Update JSON formats to latest OBI spec#195
Open
lmorchard wants to merge 2 commits intomozilla:masterfrom
Open
Fix #158: Update JSON formats to latest OBI spec#195lmorchard wants to merge 2 commits intomozilla:masterfrom
lmorchard wants to merge 2 commits intomozilla:masterfrom
Conversation
Contributor
lmorchard
commented
Jan 24, 2014
lmorchard
commented
- Update OBI serialization in Badge and Award to match the latest spec
- {badge,award}.get_absolute_url has a format='json' option
- New URL at issuer.json that serves up the BADGER_SITE_ISSUER data
- Updated BADGER_SITE_ISSUER setting
- Tests
* Update OBI serialization in Badge and Award to match latest spec:
https://github.com/mozilla/openbadges-specification/blob/master/Assertion/latest.md
* {badge,award}.get_absolute_url has a format='json' option
* New URL at issuer.json that serves up the BADGER_SITE_ISSUER data
* Updated BADGER_SITE_ISSUER setting
* See test_settings.py for an example
* Tests
This was referenced Jan 24, 2014
Member
There was a problem hiding this comment.
Having said that, part of me thinks we shouldn't provide a default here. Instead we should throw a YOIMPROPERLYCONFIGUREDERRORRZ kind of thing.
Member
|
Finished going through this. After you land this, I'll go through and make issues out of whatever looked funny. I don't think any of my comments are things that need to change right now. One thing I didn't do was go read through the OBI spec to make sure it's implemented right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.