Skip to content
This repository was archived by the owner on Dec 17, 2019. It is now read-only.

Fix #196: Revise awards JSON feed format#197

Open
lmorchard wants to merge 1 commit intomozilla:masterfrom
lmorchard:196-obi-displayer-feed
Open

Fix #196: Revise awards JSON feed format#197
lmorchard wants to merge 1 commit intomozilla:masterfrom
lmorchard:196-obi-displayer-feed

Conversation

@lmorchard
Copy link
Contributor

Tweaks to JSON feeds to make them hopefully more useful by code targeted at the OBI backpack displayer API

  • Awards JSON feed format now looks more like the OpenBadges Backpack
    Displayer format.
  • Recent badges JSON feed lists BadgeObjects under 'badges' property
  • Test updates

* Awards JSON feed format now looks more like the OpenBadges Backpack
  Displayer format.

    * JSON object with 'badges' property, listing award assertions

    * See also: https://github.com/mozilla/openbadges/wiki/Displayer-API

* Recent badges JSON feed lists BadgeObjects under 'badges' property

* Test updates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funky! I had no idea you could do that. I have countless places where that would have made life a lot easier.

@willkg
Copy link
Member

willkg commented Jan 31, 2014

This is failing with this:

======================================================================

ERROR: test_award_json_feeds (badger.tests.test_feeds.BadgerFeedsTest)

----------------------------------------------------------------------

Traceback (most recent call last):

File "/home/travis/build/mozilla/django-badger/badger/tests/test_feeds.py", line 134, in test_award_json_feeds

b1.get_absolute_url(format='json'))

File "/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/django/utils/functional.py", line 11, in _curried

return _curried_func(*(args+moreargs), **dict(kwargs, **morekwargs))

File "/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/django/db/models/base.py", line 883, in get_absolute_url

return settings.ABSOLUTE_URL_OVERRIDES.get('%s.%s' % (opts.app_label, opts.module_name), func)(self, *args, **kwargs)

TypeError: get_absolute_url() got an unexpected keyword argument 'format'

-------------------- >> begin captured stdout << ---------------------

I think that format thing is in the other PR. Is that right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants