fix(settings): group connected services by deviceId to avoid name merging

[sreecharan-desu]

Fixes #17370. Devices sharing the same name were incorrectly being merged in the 'Connected Services' list because they were grouped solely by name. This PR changes the grouping logic to use 'deviceId' as the primary key (falling back to 'name' for non-sync clients), ensuring that distinct devices with the same name are correctly shown as separate entries. It also updates the 'disconnect all' logic to correctly handle multiple sessions for the same physical device.

[MagentaManifold]

Not sure if you can see CI output, but unfortunately this PR does not compile/build.

> nx run fxa-settings:build-ts

src/components/Settings/ConnectedServices/index.test.tsx(156,37): error TS2339: Property 'groupedByName' does not exist on type '{ groupedByDevice: Dictionary<AttachedClient[]>; sortedAndUniqueClients: AttachedClient[]; }'.

I recommend running the stack locally (which is, admittedly, not easy) before submitting PRs.

[sreecharan-desu]

Thanks for flagging this. I’ve identified the issue with groupedByName in the test and am working on a fix.

[sreecharan-desu]

Fix Applied

• Removed the outdated groupedByName usage
• Updated test assertions to match the current return type
• Verified locally using nx run fxa-settings:build-ts

CI is now passing. Thanks for the review.

[sreecharan-desu]

Note: This PR was closed while I was fixing the GPG signing and rebasing onto main.

I’ve recreated the fix cleanly with a signed commit here: #20041.

Thanks for your patience.