Skip to content

Conversation

@dschom
Copy link
Contributor

@dschom dschom commented Feb 11, 2026

Because

  • We want to stop using fxa-shared/sentry code and start using the helper code we migrated to libs

This pull request

  • Added shorter TypeScript path aliases (@fxa/sentry-*) in tsconfig.base.json
  • Updated 25 files across auth-server, content-server, settings, admin-panel, event-broker, and payments-server
  • Removed tagCriticalEvent usage (deprecated)
  • Added tracesSampler support to SentryConfigOpts types
  • Deleted legacy packages/fxa-shared/sentry/ directory and tests
  • Removed sentry exports from fxa-shared package.json

Issue that this pull request solves

Closes: FXA-9920

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

This was done almost entirely by Claude

@dschom dschom requested a review from a team as a code owner February 11, 2026 01:20
Copy link
Contributor

@vbudhram vbudhram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looksl ike some build errors

@dschom
Copy link
Contributor Author

dschom commented Feb 11, 2026

Putting back in draft...

@dschom dschom marked this pull request as draft February 11, 2026 18:36
…kages

Migrated all Sentry imports from the legacy fxa-shared/sentry module to the new
scoped @fxa/sentry-* packages in libs/shared/:
- Browser code: @fxa/shared/sentry/browser
- Node.js code: @fxa/sentry-node
- Shared utilities: @fxa/sentry-utils

Changes:
- Added shorter TypeScript path aliases (@fxa/sentry-*) in tsconfig.base.json
- Updated 25 files across auth-server, content-server, settings, admin-panel,
  event-broker, and payments-server
- Removed tagCriticalEvent usage (deprecated)
- Added tracesSampler support to SentryConfigOpts types
- Deleted legacy packages/fxa-shared/sentry/ directory and tests
- Removed sentry exports from fxa-shared package.json
- Ports fxa-shared/monitoring to libs
- Updates references to fxa-shared/monitoring

This completes the migration to the modular sentry package structure.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@dschom dschom force-pushed the use-sentry-from-libs branch from b01dcb7 to f8eec3f Compare February 12, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants