Skip to content

feat(settings): Add passkey to MFA scopes #20047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MagentaManifold merged 1 commit into from
Feb 12, 2026
+13 −5
Merged

feat(settings): Add passkey to MFA scopes #20047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/fxa-auth-server/config/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2672,7 +2672,7 @@ const convictConf = convict({
env: 'MFA__ENABLED',
},
actions: {
default: ['test', '2fa', 'email', 'recovery_key', 'password'],
default: ['test', '2fa', 'email', 'recovery_key', 'password', 'passkeys'],
doc: 'Actions protected by MFA',
format: Array,
env: 'MFA__ACTIONS',
Expand Down
5 changes: 2 additions & 3 deletions packages/fxa-settings/src/components/Settings/SubRow/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,12 +463,11 @@ export const PasskeySubRow = ({
/>
{deleteModalRevealed && (
<MfaGuard
// TODO: replace with actual required scope and reason when available
requiredScope="test"
requiredScope="passkeys"
onDismissCallback={async () => {
hideDeleteModal();
}}
reason={MfaReason.test}
reason={MfaReason.removePasskey}
>
<Modal
onDismiss={hideDeleteModal}
Expand Down
11 changes: 10 additions & 1 deletion packages/fxa-settings/src/lib/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ export enum MfaReason {
createBackupCodes = 'create backup codes',
createRecoveryKey = 'create recovery key',
removeRecoveryKey = 'remove recovery key',
createPasskey = 'create passkey',
renamePasskey = 'rename passkey',
removePasskey = 'remove passkey',
test = 'test',
}

Expand Down Expand Up @@ -92,4 +95,10 @@ export type TotpInfo = {
secret: string;
};

export type MfaScope = 'test' | '2fa' | 'email' | 'recovery_key' | 'password';
export type MfaScope =
| 'test'
| '2fa'
| 'email'
| 'recovery_key'
| 'password'
| 'passkeys';
Loading