Skip to content

Coerce from strings to their proper types (NOT MORE) + code review on coercing #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
A-312 wants to merge 10 commits into from
Closed

Coerce from strings to their proper types (NOT MORE) + code review on coercing #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
19e7f9f
[Remove dependencies] Convert some default format to external package…
A-312 Dec 15, 2019
9066f56
Update CHANGELOG
madarche Dec 15, 2019
30bcc2e
Regenerating package-lock.json
madarche Dec 28, 2019
653cbc4
fix test
A-312 Dec 20, 2019
b1dea14
Coerce from strings to their proper types (NOT MORE)
A-312 Dec 7, 2019
ad6b246
Remove not used argument in addDefaultValues
A-312 Dec 7, 2019
5951c72
code review : coerce function need only 2 args
A-312 Jan 1, 2020
e249059
code review : variable names more accurate and use const instead let
A-312 Dec 8, 2019
fbd4cea
code review : magic coerceing - Save the format name in schema
A-312 Dec 8, 2019
9c853ba
add magic_corceing test
A-312 Jan 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
node_modules/*
test/coverage/*

node_modules
4 changes: 2 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
*~
/node_modules
node_modules
npm-debug.log
/test/coverage
packages/convict/test/coverage
3 changes: 0 additions & 3 deletions .istanbul.yml
View file
Open in desktop

This file was deleted.

7 changes: 7 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,16 @@ language: node_js

sudo: false

cache:
directories:
- node_modules

node_js:
- "stable"
- "lts/*"

install:
- npm run bootstrap:ci

script:
- npm run test:ci
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
## [6.0.0] - 2019-XX-XX
### Changed

- Remove json5 dependency and make it an optional parser #326 (A-312)
- [BREAKING] Multi-packages split #327 (A-312)
- [BREAKING] Remove json5 dependency and make it an optional parser #326 (A-312)

## [5.2.0] - 2019-10-12
### Added
Expand Down
Loading