Extract Lang attribute for marked contents#20407
Extract Lang attribute for marked contents#20407edoardocavazza wants to merge 5 commits intomozilla:masterfrom
Conversation
test/unit/api_spec.js
Outdated
| const pdfDoc = await loadingTask.promise; | ||
| const pdfPage = await pdfDoc.getPage(1); | ||
|
|
||
| pdfDoc.annotationStorage.setValue("30R", { value: "test" }); |
There was a problem hiding this comment.
There is no annotations in the pdf so I don't see the point of setting these values.
There was a problem hiding this comment.
Uh I am sorry, bad copy/paste from a previous test. Removed
|
Could you rebase your patch ? |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d64eb63a5678ba9/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0d18703028e4f9f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0d18703028e4f9f/output.txt Total script time: 60.00 mins |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d64eb63a5678ba9/output.txt Total script time: 75.18 mins
Image differences available at: http://54.193.163.58:8877/d64eb63a5678ba9/reftest-analyzer.html#web=eq.log |
|
@edoardocavazza Can you check the failure in issue12909 ? |
|
The If some of the elements in the text layer are going to have a different language, we need to make sure to get the measurements with the appropriate canvas context (this might be what's causing the horizontal scaling difference in |
5 participants
Some marked contents have a
Langattribute defined in the props passed to thebeginMarkedContentPropsoperator. With this PR, the evaluator extracts this information. I chose to pass thepropsobject as third argument in order to maintain backwards compatibility, but I'm open to changes.