Skip to content

a11y: show toolbar tooltips on keyboard focus (Fixes #19156) #20558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
enterayush wants to merge 1 commit into from
+16 −0
Closed

a11y: show toolbar tooltips on keyboard focus (Fixes #19156) #20558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions web/viewer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,6 +843,22 @@ dialog :link {
height: auto;
}
}
/* Show tooltips for keyboard users */
Copy link
Contributor

@timvandermeij timvandermeij Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that there is always a newline between sections, so above this comment.

&:focus::after,
&:hover::after {
content: attr(title);
Copy link
Contributor

@timvandermeij timvandermeij Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non-keyboard use, so on hover, this now duplicates the tooltips that the browser already shows up default, and they are on top of each other which doesn't seem like good UX:

Image

position: absolute;
top: 100%;
left: 50%;
Copy link
Contributor

@timvandermeij timvandermeij Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't take in account strings that are longer or are at the edge of the viewer, such as the secondary toolbar button in the Dutch locale, which also creates a horizontal scrollbar:

Image

transform: translateX(-50%);
white-space: nowrap;
background: rgb(0 0 0 / 0.8);
color: #fff;
padding: 4px 6px;
border-radius: 4px;
font-size: 12px;
pointer-events: none;
}
}

.toolbarButtonWithContainer {
Expand Down