fix(display): allow text selection under markup annotations#20563
fix(display): allow text selection under markup annotations#20563kairosci wants to merge 2 commits intomozilla:masterfrom
Conversation
…zilla#18190) Add pointer-events: none to markup annotation containers to prevent blocking text selection. Add integration test.
6a433b8 to
b4476d9
Compare
|
Not sure if you intended to flag l10n for review or something else. It doesn't look like localization is affected. |
|
@bcolsson I do not understand what you are referring to, in any case the change does not affect nor refers to internationalization. |
You triggered a review from @mozilla/pdfjs-l10n (likely you pushed changes to a .ftl file at some point). |
Could you link it to me? Thanks! |
Not sure what you're asking to link to. There are rules triggering automated review requests, depending on which files you touch Touching .ftl files will trigger a review from Bryan's (and my) group. |
|
It seems strange to me, since I haven't modified any ftl files. Should I close the PR, or is there an alternative way to have it reviewed by the appropriate group? |
|
@timvandermeij If you can, please let me know how to proceed, thank you! |

Fixes #18190.
This PR addresses a regression where text underneath highlight, underline, squiggly, and strikeout annotations could not be selected.
The cause was
pointer-events: autoon the annotation container elements, which blocked mouse events from reaching the text layer.Changes:
pointer-events: noneto.highlightAnnotation,.underlineAnnotation,.squigglyAnnotation, and.strikeoutAnnotationinweb/annotation_layer_builder.css.test/integration/highlight_selection_spec.mjsto verify that the pointer-events property is correctly set to 'none'.Verification: