Skip to content

Conversation

@janbrasna
Copy link
Contributor

The SVG icons either need to be at 16px (like fx, fb, ig, gh, pocket…) or if 24px or any other size (e.g. spotify, tiktok & mastodon) only the viewBox without width and height must be present to work in bedrock footer background-image in WebKit.

Mastodon SVG icons are the only ones in 24px that also declare dimensions, making migration to protocol_assets buggy:

Screenshot 2024-04-17 at 21 09 49

(PoC: janbrasna/bedrock@5653020)

Leaving out the dimensions fixes this and enables removal of the local overrides in footer.

@craigcook
Copy link
Contributor

I think whichever size we choose, either 16x16 or 24x24, we should be consistent across all of them. I tend to include width and height in addition to viewBox so it still has a "natural" size when its viewed on its own. So maybe we should resize Mastodon to 16 x 16 and keep the dimension attributes, and do the same for the others that are 24 x 24.

@janbrasna
Copy link
Contributor Author

Even better! I think the original icons' 16px form factor w/ explicit dimensions is a good idea to match for consistency — I'll make all the newer social icons that size too.

I originally didn't want to resize or otherwise touch the shapes so this felt like a quick fix, but it's sorted out downstream for now with bg contain so there's no pressure and we can fixup all of them…

@janbrasna janbrasna marked this pull request as draft June 13, 2024 13:23
@janbrasna janbrasna changed the title Fix dimensions for Mastodon icons Fix dimensions for newer social icons Jun 13, 2024
@stephaniehobson
Copy link
Contributor

@janbrasna What is the state of this draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants