Simplify split component by removing pop options (#896) #1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Split component by removing the "pop" layout options that allowed media to protrude beyond the top and/or bottom edges of the container. The change removes three CSS classes (mzp-l-split-pop-top, mzp-l-split-pop-bottom, and mzp-l-split-pop) and their associated styles.
Changes:
- Removed pop-related CSS classes and ~200 lines of Sass styling from the Split component
- Updated documentation to remove references to pop functionality and add migration guidance
- Added migration instructions for finding and removing pop class usages
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/02-usage/migration.md | Added migration section with instructions for removing pop classes and finding usages |
| components/split/split.config.yml | Removed pop-out media variant and updated notes to remove references to pop functionality |
| components/split/readme.md | Removed documentation about pop classes from the component readme |
| assets/sass/protocol/components/_split.scss | Removed ~200 lines of Sass code implementing pop layout styles and fixed typo in comment |
| CHANGELOG.md | Added breaking change entry for removed Split component classes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stephaniehobson
force-pushed
the
simple-split
branch
from
4039b1b to
bc4ffcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify split component by removing pop options
CHANGELOG.md.Issue
Fix #896
Testing
Did I get all references?