Correct linker-wrapper script under Msys2 and Cygwin. Fixes #58#59
Correct linker-wrapper script under Msys2 and Cygwin. Fixes #58#59SquallATF wants to merge 1 commit intomozilla:masterfrom
Conversation
|
@SquallATF thanks for the patch. This is more complicated than I am comfortable, mostly because you choose to "do it right" and use However, I'd like to understand why you bounce from Finally, I have ticket #49 to stop using Python for the linker wrapper entirely. I don't think it's needed, since we're just invoking. If you were to instead fix #49, and just invoke in the If there's some hard blocker to doing #49 and then this work, I'm inclined to accept this patch: I have only nits and style preferences. Thanks again! |
|
Update patch, remove python path convert and convert it from if use |
|
@SquallATF I'm sorry that I haven't responded -- I've been very busy with work and family. I expect to merge this fix but I haven't had time to work through the "don't use Python" details myself just yet. Thanks again, for the patch and for your patience. |
Because rustc can not run shell script under windows bash, so make a hack in
linker-wrapper.bat, ifSEHLLvariable is defind and findcygpaththen try run shell script. Otherwise the default behavior will be usedAnother fix is convert
RUST_ANDROID_GRADLE_CCto unix path when run with native python under Msys2 and Cygwin. if run with native python under Msys2 and Cygwin thesubprocessneed executable file path in unix format.