Open
Conversation
Member
|
Thanks for the patch! I'm terribly busy, just coming off a few vacation days and catching up, but I'll try to process this within a week. |
ncalexan
requested changes
Oct 13, 2021
Member
ncalexan
left a comment
There was a problem hiding this comment.
Some general comments.
- Please include a note about this task in
README.md. - Does this, in fact, work? I recall that the plugin sets the Cargo target directory based on the architecture. Does running
cargo cleanactually remove everything? - Does
cargoClean${ARCHITECTURE}make sense? My preference is to generalize the cargo command invocation framework to supportcleanbut alsotestand friends. - Finally, could you try to add a simple automated test that this in fact works? I'm aware that this adds to the work, but I'd like to improve the testing story as we add features.
I'm marking this as "Request changes" simply for the README.md request, which needs to be done before landing. But I'd like to get some discussion and hopefully some progress on the other questions and testing.
Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.