Skip to content

Do not merge commits without PR number or with PR number set to "0". #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lutien merged 1 commit into from
Feb 3, 2026
Merged

Do not merge commits without PR number or with PR number set to "0". #2705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sync/landing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,10 @@ def unlanded_wpt_commits_by_pr(
wpt_commit = sync_commit.WptCommit(git_wpt, commit.hexsha)
pr = wpt_commit.pr()
extra_commits = []
if pr not in index_by_pr:

# If we fail to identify the PR number or the PR number is set to `0`,
# do not try to group it with other commits.
if pr is None or pr == 0 or pr not in index_by_pr:
pr_data: tuple[int | None, list[WptCommit]] = (pr, [])
# If we have a merge commit, also get the commits merged in
if len(commit.parents) > 1:
Expand Down