Fix SonarCloud python:S6437 — remove hard-coded DB password#13
Open
mpchenette wants to merge 1 commit intomainfrom
Open
Fix SonarCloud python:S6437 — remove hard-coded DB password#13mpchenette wants to merge 1 commit intomainfrom
mpchenette wants to merge 1 commit intomainfrom
Conversation
…vars for MySQL connection
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the open code scanning alert (SonarCloud
python:S6437) by removing the hard-coded MySQL credential inpython/sql.pyand switching to environment-based configuration:osimport and readDB_USER,DB_PASSWORD,DB_HOST,DB_NAMEfrom the environment (with sensible defaults except for password).Follow-ups suggested (not in this PR):
search_user()andadd_user().add_user()connection call (mysql.connector.connect(...)).Please set
DB_PASSWORD(and other optional vars) in your environment before running.