Add consistent pagination support with limit/offset parameters#12
Merged
awagner-mainz merged 5 commits intomainfrom Feb 8, 2026
Merged
Add consistent pagination support with limit/offset parameters#12awagner-mainz merged 5 commits intomainfrom
awagner-mainz merged 5 commits intomainfrom
Conversation
- Add limit and offset parameters to SQL queries for GetAllProjects, GetSharedUsersForDefinition, and GetSharedUsersForInstance - Add limit/offset to request models for GetDefinitionSharedUsersRequest and GetInstanceSharedUsersRequest - Update all handler functions to properly use limit/offset parameters - Replace hardcoded limits (999) with maxSharedUsersPerQuery constant for internal queries - Keep large limits for admin functions that need all records (sanity check) Co-authored-by: awagner-mainz <2088443+awagner-mainz@users.noreply.github.com>
- Add test to verify pagination works correctly with limit and offset - Test validates that limit parameter correctly limits results - Test confirms responses are properly formatted Co-authored-by: awagner-mainz <2088443+awagner-mainz@users.noreply.github.com>
- Add maxAdminQueryLimit constant with documentation for admin operations - Document that maxAdminQueryLimit is used for sanity checks that need all records - Improve code clarity and maintainability Co-authored-by: awagner-mainz <2088443+awagner-mainz@users.noreply.github.com>
- Document user-facing endpoints use input.Limit/Offset for pagination - Document internal authorization checks use maxSharedUsersPerQuery - Improve code clarity for future maintainers Co-authored-by: awagner-mainz <2088443+awagner-mainz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add consistent pagination support for lists
Add consistent pagination support with limit/offset parameters
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List endpoints lacked consistent pagination support. Several queries had no pagination parameters, and handlers used hardcoded limits.
Changes
SQL Queries
LIMIT/OFFSETtoGetAllProjects,GetSharedUsersForDefinition,GetSharedUsersForInstancesqlc generateRequest Models
limit(default: 100, max: 200) andoffset(default: 0) to:GetDefinitionSharedUsersRequestGetInstanceSharedUsersRequestHandler Functions
Limit: 999with appropriate pagination:input.Limit/input.Offsetfrom requestmaxSharedUsersPerQueryconstant (1000)maxAdminQueryLimitconstant (999999)Example
Pattern
User-facing list endpoints now accept query parameters. Internal operations use named constants to maintain correct authorization semantics.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.