Fix type mismatches for nullable dimensions and context_limit fields#20
Merged
awagner-mainz merged 5 commits intomainfrom Feb 10, 2026
Merged
Fix type mismatches for nullable dimensions and context_limit fields#20awagner-mainz merged 5 commits intomainfrom
awagner-mainz merged 5 commits intomainfrom
Conversation
Co-authored-by: awagner-mainz <2088443+awagner-mainz@users.noreply.github.com>
Co-authored-by: awagner-mainz <2088443+awagner-mainz@users.noreply.github.com>
Co-authored-by: awagner-mainz <2088443+awagner-mainz@users.noreply.github.com>
Co-authored-by: awagner-mainz <2088443+awagner-mainz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix compilation errors in llm_services.go
Fix type mismatches for nullable dimensions and context_limit fields
Feb 10, 2026
Contributor
|
Code looks good, tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration 004 made
dimensionsandcontext_limitnullable in thedefinitionstable, but generated models still usedint32instead ofpgtype.Int4, causing compilation errors when assigning values.Changes
005_make_dimensions_nullable.sqlto makeinstances.dimensionsnullable (was only done fordefinitions)dimensionsandcontext_limitare nowpgtype.Int4in bothDefinitionandInstancestructsint32) and database layer (pgtype.Int4).Int32on nullable fields in critical paths (embedding validation, similarity search)Pattern
Enables database migration from v003 schemas where these fields may be unset.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.