Refactor Encoders and add JSON support#93
Open
erikgaal wants to merge 2 commits intompociot:masterfrom
Open
Conversation
Collaborator
Contributor
|
@nonoesp since we're starting to use this more in our company, is there something I can start helping with to review / add tests so we can get some of these things moving forward ? Json support is something we're going to need, and I think it would be nice to do it part of this and not a fork. |
Collaborator
|
@CoolGoose Hey! I have limited bandwidth for this. But I'll be happy to chat and let you maintain this package if you'd like. =) |
Contributor
|
I can give it a try since I should be able to have a few hours per week for this. Let me review this PR first, and see how this goes ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds upon #83 and refactors it a bit to provide a clear solution. Also rebased the PR so it's up to date with the trunk.
Thanks @lsmith77 for the original PR!