API: argument order (breaking external Nim/C/Go/Rust EIP-4844 API#394
Merged
API: argument order (breaking external Nim/C/Go/Rust EIP-4844 API#394
Conversation
… of Ethereum KZG EIP-4844)
Owner
Author
|
1 windows CI failed due to a bad mingw mirror |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the threadpool to always be first argument. It is the most "global" of the context, because it's at library/app level and not just KZG or BLS signatures.
As powers-of-tau and polynomial domains are also contexts, they are moved in front and this impacts KZG and IPA modules.
Furthermore, document the API.
It is inspired by libsecp256k1:
This breaks Nim, C, Go, Rust API and should be done now before we cut the first ever Constantine release.
This impacts Grandine's branch: #331