Make specularGlossiness inherit from MeshStandardMaterial#18474
Merged
mrdoob merged 9 commits intomrdoob:devfrom Jan 24, 2020
Merged
Make specularGlossiness inherit from MeshStandardMaterial#18474mrdoob merged 9 commits intomrdoob:devfrom
mrdoob merged 9 commits intomrdoob:devfrom
Conversation
mrdoob
reviewed
Jan 24, 2020
examples/js/loaders/GLTFLoader.js
Outdated
Comment on lines
+697
to
+698
| }, | ||
| specularMap: { |
Owner
|
Thanks! |
Contributor
|
I think I need envoys for my PRs, when my name is directly behind them they tend to get stuck :) I cleaned it up 6-7 times, but oh well, hopefully one of these days I’ll get some git blame. |
Owner
|
Try submitting your next PR with a different username 😝 |
Contributor
|
Looks like the way to go :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18463
I've just taken #14099 by @pailhead and fixed the conflicts to update it. I made only a couple of minor fixes of my own that you can see in the last commit. This replaces my first failed effort at fixing this problem in #18465; the approach from this old PR both fixes the problem and also cleans up the code nicely. It also makes it unnecessary to delve into the gltf.parser.extensions to allow this material to be cloned; it just happens automatically!