NodeMaterial: getHash and customProgramCacheKey#19833
Conversation
|
|
|
@sunag ready to be merged? |
Yes! |
examples/jsm/nodes/core/Node.js
Outdated
| var hash = '{'; | ||
| var prop, obj; | ||
|
|
||
| for(prop in this) { |
There was a problem hiding this comment.
@mugen said
I can clean things up after merging. Don't be worry about this
Please be consistent. If users are not expected to follow the three.js code style, then please remove the instructions to do so found in https://github.com/mrdoob/three.js/wiki/How-to-contribute-to-three.js.
Format whitespace consistently with the rest of code base. See the [an] article Mr.doob's-Code-Style™, and the online code beautifier. It is highly recommended to use ESLint plugin and appropriate settings in your code editor.
/ping @mrdoob
There was a problem hiding this comment.
@WestLangley I see no problem in fix this... so far I thought that you is referring to the json output.
There was a problem hiding this comment.
Sorry, just wanted to get this merged quickly 🤓.
|
Thanks! |
Node.getHash()orNodeMaterial.getHash()generate a JSON.This approach building the string is more fast that
array.joinandJSON.stringify.