GLTFLoader: Support animation loading via extension#23810
Merged
mrdoob merged 1 commit intomrdoob:devfrom Mar 31, 2022
Merged
Conversation
marwie
changed the title
donmccurdy
approved these changes
Mar 29, 2022
Owner
|
Thanks! |
abernier
pushed a commit
to abernier/three.js
that referenced
this pull request
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: GLTF KHR_animation
Description.
This PR replaces the direct call to
loadAnimationwith the_invokeOnecall to allow extensions to handle loading of AnimationClips to start working on an implementation of the GLTF KHR_animation2 proposalThis contribution is funded by 🌵 Needle.